Re: [PATCH v4 07/26] media: mc: Drop media_dev description from struct media_devnode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This needs a proper commit log.

Specifically it should mention that due to the revert in patch 05/26
the media_dev field was deleted, but that that revert didn't remove it
from the kerneldoc comments.

I would also suggest that you move this patch to 06/26 so that it
comes right after the 05/26 revert, since the two really belong together.

With that, you can add my:

Acked-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx>

Regards,

	Hans

On 10/06/2024 12:05, Sakari Ailus wrote:
> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> ---
>  include/media/media-devnode.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/media/media-devnode.h b/include/media/media-devnode.h
> index 1117d1dfd6bf..024dfb98a6fd 100644
> --- a/include/media/media-devnode.h
> +++ b/include/media/media-devnode.h
> @@ -55,7 +55,6 @@ struct media_file_operations {
>  
>  /**
>   * struct media_devnode - Media device node
> - * @media_dev:	pointer to struct &media_device
>   * @fops:	pointer to struct &media_file_operations with media device ops
>   * @dev:	pointer to struct &device containing the media controller device
>   * @cdev:	struct cdev pointer character device





[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux