On Tue, May 28, 2024 at 04:51:46PM +0530, Devarsh Thakkar wrote: > On 28/05/24 02:07, Andy Shevchenko wrote: [..] > >> +#include <kunit/test.h> > >> +#include <linux/gcd.h> > >> +#include <linux/lcm.h> > > > > + math.h (where abs()/DIV_ROUND_*()/etc come from?) > > I believe I mentioned that. > > > > I did compile and test this, so math.h was indirectly getting included via > some other header file already included but I would not rely on that and > include math.h separately as you suggested. Please, follow the IWYU principle, what you are suggesting is a fragile approach. > >> +#include <linux/reciprocal_div.h> -- With Best Regards, Andy Shevchenko
