Hi Andy,
Thanks for the review.
On 28/05/24 02:07, Andy Shevchenko wrote:
[..]
>> +#include <kunit/test.h>
>> +#include <linux/gcd.h>
>> +#include <linux/lcm.h>
>
> + math.h (where abs()/DIV_ROUND_*()/etc come from?)
> I believe I mentioned that.
>
I did compile and test this, so math.h was indirectly getting included via
some other header file already included but I would not rely on that and
include math.h separately as you suggested.
>> +#include <linux/reciprocal_div.h>
>
> ...
>
>> +MODULE_LICENSE("GPL");
>
> modpost validator won't be happy about this, i.e. missing MODULE_DESCRIPTION().
>
Indeed, it gives below logs, let me add that too.
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/math/math_kunit.o
Regards
Devarsh
