Re: [PATCH 05/10] saa7134: protect the ir user count

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 22, 2010 at 02:55:42PM -0200, Mauro Carvalho Chehab wrote:
>Em 19-11-2010 21:43, David Härdeman escreveu:
>> The use of the saa7134_card_ir->users seems racy, so protect the count with
>> a spinlock. Also use proper data types as arguments to __saa7134_ir_start()
>> and __saa7134_ir_stop() to remove some unnecessary casts.
>
>
>Hmm... instead of using a spinlock, the better seems to use an atomic_t.

I don't think it would work since e.g. saa7134_ir_stop() needs to check
the current user count and then (depending on the user count) run
__saa7134_ir_stop().

-- 
David Härdeman
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux