Em 19-11-2010 21:43, David HÃrdeman escreveu: > int to bool conversion for module parameters which are truely boolean. > > Signed-off-by: David HÃrdeman <david@xxxxxxxxxxx> > --- > drivers/media/video/saa7134/saa7134-input.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/video/saa7134/saa7134-input.c b/drivers/media/video/saa7134/saa7134-input.c > index 8b80efb..aea74e2 100644 > --- a/drivers/media/video/saa7134/saa7134-input.c > +++ b/drivers/media/video/saa7134/saa7134-input.c > @@ -29,12 +29,12 @@ > > #define MODULE_NAME "saa7134" > > -static unsigned int disable_ir; > -module_param(disable_ir, int, 0444); > +static bool disable_ir; > +module_param(disable_ir, bool, 0444); > MODULE_PARM_DESC(disable_ir,"disable infrared remote support"); > > -static unsigned int ir_debug; > -module_param(ir_debug, int, 0644); > +static bool ir_debug; > +module_param(ir_debug, bool, 0644); > MODULE_PARM_DESC(ir_debug,"enable debug messages [IR]"); Not sure about this patch. Debug parameters may be useful to be integer, as we may need to add more levels to the debug. Yet, maybe the better would be to just use dynamic_printk for all those stuff (e. g. converting them to use dev_dbg), as we can enable/disable the debug messages per-line, via debugfs. Comments? Cheers, mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
