On Mon, Nov 22, 2010 at 9:55 PM, Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> wrote: > Em 17-11-2010 10:28, Manu Abraham escreveu: >> On Wed, Nov 17, 2010 at 7:48 AM, Mauro Carvalho Chehab >> <mchehab@xxxxxxxxxx> wrote: >>> Em 14-11-2010 18:48, Manu Abraham escreveu: >>>> Mauro, >>>> >>>> Please pull from http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/ >>>> >>>> for the following changes. >>>> >>>> >>>> changeset 15168:baa4e8008db5 Mantis, hopper: use MODULE_DEVICE_TABLE >>>> http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/baa4e8008db5 >>>> >>>> changeset 15169:f04605948fdc Mantis: append tasklet maintenance for >>>> DVB stream delivery >>>> http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/f04605948fdc >>>> >>>> changeset 15170:ee7a63d70f94 Mantis: use dvb_attach to avoid double >>>> dereferencing on module removal >>>> http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/ee7a63d70f94 >>>> >>>> changeset 15171:3a2ece3bf184 Mantis: Rename gpio_set_bits to >>>> mantis_gpio_set_bits >>>> http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/3a2ece3bf184 >>>> >>>> changeset 15172:56c20de4f697 stb6100: Improve tuner performance >>>> http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/56c20de4f697 >>>> >>>> changeset 15173:5cc010e3a803 stb0899: fix diseqc messages getting lost >>>> http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/5cc010e3a803 >>> >>> Applied, thanks. >>> >>> A new warning appeared: >>> >>> drivers/media/dvb/frontends/stb6100.c:120: warning: ‘stb6100_normalise_regs’ defined but not used >> >> >> Can you please enclose the function in a #if 0.since it is not being used. > > The enclosed patch should fix the warning. > > --- > > > [media] stb6100: warning cleanup > > drivers/media/dvb/frontends/stb6100.c:120: warning: ‘stb6100_normalise_regs’ defined but not used > > Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> Acked-by: Manu Abraham <manu@xxxxxxxxxxx> > > diff --git a/drivers/media/dvb/frontends/stb6100.c b/drivers/media/dvb/frontends/stb6100.c > index db66248..64673b8 100644 > --- a/drivers/media/dvb/frontends/stb6100.c > +++ b/drivers/media/dvb/frontends/stb6100.c > @@ -117,7 +117,10 @@ static const struct stb6100_regmask stb6100_template[] = { > [STB6100_TEST3] = { 0x00, 0xde }, > }; > > -static void stb6100_normalise_regs(u8 regs[]) > +/* > + * Currently unused. Some boards might need it in the future > + */ > +static inline void stb6100_normalise_regs(u8 regs[]) > { > int i; > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html