On Friday 19 November 2010 14:26:42 Laurent Pinchart wrote:
> Some buggy sensors generate corrupt frames when the stream is started.
> This new operation returns the number of corrupt frames to skip when
> starting the stream.
Looks OK, but perhaps the two should be combined to one function?
I also have my doubts about the sensor_ops in general. I expected originally
to see a lot of ops here, but apparently there is little or no need for it.
Do we expect to see this grow, or would it make more sense to move the ops
to video_ops? I'd be interested to hear what sensor specialists think.
Regards.
Hans
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> include/media/v4l2-subdev.h | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
> index 04878e1..b196966 100644
> --- a/include/media/v4l2-subdev.h
> +++ b/include/media/v4l2-subdev.h
> @@ -291,9 +291,13 @@ struct v4l2_subdev_pad_ops {
> * This is needed for some sensors, which always corrupt
> * several top lines of the output image, or which send their
> * metadata in them.
> + * @g_skip_frames: number of frames to skip at stream start. This is needed for
> + * buggy sensors that generate faulty frames when they are
> + * turned on.
> */
> struct v4l2_subdev_sensor_ops {
> int (*g_skip_top_lines)(struct v4l2_subdev *sd, u32 *lines);
> + int (*g_skip_frames)(struct v4l2_subdev *sd, u32 *frames);
> };
>
> struct v4l2_subdev_ops {
>
--
Hans Verkuil - video4linux developer - sponsored by Cisco
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
