Re: [RFC PATCH 0/2] Apple remote support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Em 18-11-2010 18:49, Jarod Wilson escreveu:
> On Thu, Nov 18, 2010 at 09:43:19PM +0100, David Härdeman wrote:
>> On Thu, Nov 18, 2010 at 11:33:04AM -0500, Jarod Wilson wrote:
>>> Mauro's suggestion, iirc, was that max scancode size should be a
>>> property of the keytable uploaded, and something set at load time (and
>>> probably exposed as a sysfs node, similar to protocols).
>>
>> I think that would be a step in the wrong direction. It would make the
>> keytables less flexible while providing no real advantages.

We can't simply just change NEC to 32 bits, as we'll break userspace ABI 
(as current NEC keycode tables use only 16 bits). So, an old table will not
worky anymore, if we do such change.

> I think it was supposed to be something you could update on the fly when
> uploading new keys, so its not entirely inflexible. Default keymap might
> be 24-bit NEC, then you upload 32-bit NEC codes, and the max scancode size
> would get updated at the same time. Of course, it probably wouldn't work
> terribly well to have a mix of 24-bit and 32-bit NEC codes in the same
> table.

There's another reason why it may be interesting to have the scancode size
stored somewhere. With the new flexible scancode size, some devices may have
bigger scancodes (I remember people mentioned some cases with 128 bits when 
we've discussed the getkeycodbig patches in the past). So, we'll need to
address some cases where the scancodes don't have 32 bits. I think that the
current maximum limit is 31 bits (as the search algorithm uses the signal
bit for some reason).

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux