On 3/28/24 14:48, Rob Herring wrote: > On Wed, Mar 27, 2024 at 05:17:08PM -0600, git@xxxxxxxxxxxx wrote: >> From: Luigi311 <git@xxxxxxxxxxxx> >> >> On some boards powerdown signal needs to be deasserted for this >> sensor to be enabled. >> >> Signed-off-by: Ondrej Jirman <megi@xxxxxx> >> --- >> .../devicetree/bindings/media/i2c/sony,imx258.yaml | 4 ++++ > > Bindings should be a separate patch. > Ok ill create separate patch for adding in the binding and then a follow up patch with the other half that actually adds it to the driver >> drivers/media/i2c/imx258.c | 13 +++++++++++++ >> 2 files changed, 17 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml >> index c7856de15ba3..0414085bf22f 100644 >> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml >> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml >> @@ -35,6 +35,10 @@ properties: >> reg: >> maxItems: 1 >> >> + powerdown-gpios: >> + description: |- > > Don't need '|-' if no formatting> Done >> + Reference to the GPIO connected to the PWDN pin, if any. >> + >> reset-gpios: >> description: |- >> Reference to the GPIO connected to the XCLR pin, if any.
