On 28 March 2024 01:06:42 GMT, Changhuang Liang <changhuang.liang@xxxxxxxxxxxxxxxx> wrote: >Hi, Conor, > >> On Mon, Jan 22, 2024 at 08:24:51AM +0000, Conor Dooley wrote: >[...] >> > > > > > Do these clocks etc exist but are not used by the driver? >> > > > > > >> > > > > > Or do they not exist at all? >> > > > > > >> > > > > > The two are very different! >> > > > >> > > > > These clocks etc exist but are not used by the driver. >> > > > >> > > > That's not an acceptable reason for removing them from the >> > > > binding. If they exist, they should be documented, regardless of >> > > > whether the driver makes use of them. NAK. >> > > >> > > If so, how to avoid the warning of dtbs_check. >> > >> > By also adding the clocks, resets and interrupts to the dts. >> >> Going through patchwork stuff now that the merge window is done. I'm gonna >> mark the dts patch as changes requeted. The binding (and dts) should >> describe all of the clocks the hardware has, whether or not you choose to use >> them all in software does not matter. Can you please resend the dts patch, >> with all of the clocks, resets and interrupts present? >> > >You have applied the dts patch. >https://lore.kernel.org/all/20240219032741.18387-1-changhuang.liang@xxxxxxxxxxxxxxxx/ Oh, sorry for the noise then. I guess I was mislead by patchwork marking this as new :)