On Mon, Jan 22, 2024 at 08:24:51AM +0000, Conor Dooley wrote: > On Mon, Jan 22, 2024 at 01:33:56AM +0000, Changhuang Liang wrote: > > > > > On Fri, Jan 19, 2024 at 12:57:22PM +0000, Changhuang Liang wrote: > > > > EXTERNAL EMAIL: Do not click links or open attachments unless you know > > > > the content is safe > > > > > > > > Hi , Conor > > > > > > > > > 主题: Re: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver > > > > > and yaml property names > > > > > > > > > > On Fri, Jan 19, 2024 at 02:06:38AM -0800, Changhuang Liang wrote: > > > > > > Drop some unused properties for clocks, resets and interrupts for > > > > > > StarFive JH7110 camera subsystem. > > > > > > > > > > What do you mean "unused"? > > > > > > > > > > Do these clocks etc exist but are not used by the driver? > > > > > > > > > > Or do they not exist at all? > > > > > > > > > > The two are very different! > > > > > > > These clocks etc exist but are not used by the driver. > > > > > > That's not an acceptable reason for removing them from the binding. If they > > > exist, they should be documented, regardless of whether the driver makes use > > > of them. NAK. > > > > If so, how to avoid the warning of dtbs_check. > > By also adding the clocks, resets and interrupts to the dts. Going through patchwork stuff now that the merge window is done. I'm gonna mark the dts patch as changes requeted. The binding (and dts) should describe all of the clocks the hardware has, whether or not you choose to use them all in software does not matter. Can you please resend the dts patch, with all of the clocks, resets and interrupts present? Thanks, Conor.
Attachment:
signature.asc
Description: PGP signature
