On Tue, 19 Mar 2024 at 13:02, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 19/03/2024 13:57, Naushir Patuck wrote: > >>>> > >>>> See writing bindings. Compatibles should be SoC specific. In some cases > >>>> generic fallbacks make sense, in some note. But don't just choose > >>>> "generic fallback" because you want. Provide rationale. > >>> > >>> If the compatible is SoC specific, I suppose "raspberrypi,rp1-cfe" > >>> would be the correct string. > >> > >> Sure, but then please think what if rp1 is on Rpi6, called exactly the > >> same (rp1), with some minor differences? Could it be? > > > > Yes, this is definitely possible. In such cases, I would expect the > > hardware to have a version register that would be queried by the > > driver to adjust for minor differences, and the compatible string > > remains the same. Does that seem reasonable? > > The "would expect" is concerning. The register(s) must be there already, > with proper value. > A version register already exists in the current hardware, so we will update it to identify future hardware revisions. Regards, Naush
