On 19/03/2024 13:06, Naushir Patuck wrote: > Hi, > > On Tue, 19 Mar 2024 at 09:32, Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: >> >> On 19/03/2024 08:00, Tomi Valkeinen wrote: >>> On 19/03/2024 08:48, Tomi Valkeinen wrote: >>>> On 19/03/2024 08:23, Krzysztof Kozlowski wrote: >>>>> On 18/03/2024 16:49, Tomi Valkeinen wrote: >>>>>> Add DT bindings for raspberrypi,rp1-cfe. >>>>>> >>>>>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx> >>>>>> --- >>>>>> .../bindings/media/raspberrypi,rp1-cfe.yaml | 103 >>>>>> +++++++++++++++++++++ >>>>>> 1 file changed, 103 insertions(+) >>>>>> >>>>>> diff --git >>>>>> a/Documentation/devicetree/bindings/media/raspberrypi,rp1-cfe.yaml >>>>>> b/Documentation/devicetree/bindings/media/raspberrypi,rp1-cfe.yaml >>>>>> new file mode 100644 >>>>>> index 000000000000..7b2beeaaab0e >>>>>> --- /dev/null >>>>>> +++ b/Documentation/devicetree/bindings/media/raspberrypi,rp1-cfe.yaml >>>>>> @@ -0,0 +1,103 @@ >>>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>>>> +%YAML 1.2 >>>>>> +--- >>>>>> +$id: http://devicetree.org/schemas/media/raspberrypi,rp1-cfe.yaml# >>>>> >>>>> Use compatible as filename. >>>> >>>> Ah, indeed. I changed the compatible quite late, adding the "rpi5" as >>>> versioning, and missed changing the file name. >>>> >>>> I'll rename. >>> >>> Actually, maybe it's better to have two compatibles, >>> "raspberrypi,rp1-cfe" as the generic one, and "raspberrypi,rpi5-rp1-cfe" >>> (or something similar) for RaspberryPi 5. >>> >>> And I'm not sure if the "rp1" part is relevant there, would >>> "raspberrypi,cfe" be just as fine? Naush? >> >> See writing bindings. Compatibles should be SoC specific. In some cases >> generic fallbacks make sense, in some note. But don't just choose >> "generic fallback" because you want. Provide rationale. > > If the compatible is SoC specific, I suppose "raspberrypi,rp1-cfe" > would be the correct string. Sure, but then please think what if rp1 is on Rpi6, called exactly the same (rp1), with some minor differences? Could it be? I don't know, you are upstreaming this stuff. Just be also sure you read writing bindings document. Best regards, Krzysztof
