Hi Florian, On Fri, Mar 15, 2024 at 07:02:38AM -0700, Florian Fainelli wrote: > On 3/1/2024 1:38 PM, Laurent Pinchart wrote: > > The subject line should obviously have read 'PATCH v6', and I should > > have updated Jean-Michel's e-mail address instead of blindly relying on > > get-maintainer.pl. Maybe sending patches on a Friday evening isn't he > > best idea after all. Sorry about that. > > > > On Fri, Mar 01, 2024 at 11:32:15PM +0200, Laurent Pinchart wrote: > >> Hello everybody, > >> > >> This patch series adds a new driver for the BCM2835 (and derivative) > >> CCP2/CSI2 camera interface named Unicam. This IP core is found in the > >> VC4-based Raspberry Pi, namely the Pi Zero, Pi 3 and Pi 4. > >> > >> Camera support for Raspberry Pi 4 currently relies on a downstream > >> Unicam driver that live in the Raspberry Pi kernel tree ([1]). The > >> driver uses the V4L2 API, but works around the lack of features in V4L2 > >> to properly support sensor embedded data. Since the Unicam driver > >> development by Raspberry Pi, some of those features have been merged in > >> the kernel (namely the V4L2 streams API) or are being developed (namely > >> generic metadata formats and subdev internal pads), with patches posted > >> for review on the linux-media mailing list ([2]). > >> > >> This new upstream driver is based on the downstream code, extensively > >> reworked to use the new V4L2 APIs. > >> > >> The series is based on top of a merge of > >> > >> - v7 of the generic metadata and internal pads, rebased on v6.8-rc5 ([3]) > >> - the downstream ISP driver ported to mainline ([4]) > >> > >> For convenience, it can be found in [5]. Note that the ISP driver is > >> getting upstreamed separately. > >> > >> The series starts with five patches that add support for streams and > >> embedded data to the imx219 driver (01/15 to 05/15). Patches 06/15 to > >> 09/15 then add the Unicam driver, with new V4L2 pixel formats (06/15 and > >> 07/15) and DT bindings (08/15) The remaining patches cover DT > >> integration (10/15 to 14/15) with a sample DT overlay for the IMX219 > >> camera module (15/15). > > I am really keen on taking the DTS patches now so you know those are > taken care of, make it to linux-next shortly and then we can focus on > the drivers/media aspects. Stefan, does that work for you? 10/15 and 11/15 should be fine to merge already, although 11/15 depends on the DT bindings in 08/15. Even if the unicam driver needs a respin, I think the bindings are safe to merge already. Do you plan to take them in your tree with the corresponding DTS patches ? For 12/15 (the pinctrl-based I2C multiplexing), I'd really like an ack from Dave. 13/15 is pretty straightforward but depends on 12/15. 14/15 is independent from all the other patches and can safely be merged I think. -- Regards, Laurent Pinchart
