On Sat, Mar 16, 2024 at 10:46:52AM +0100, Niklas Söderlund wrote: > Hi Dan, > > On 2024-03-04 14:16:56 +0300, Dan Carpenter wrote: > > On Mon, Mar 04, 2024 at 10:48:47AM +0000, Sakari Ailus wrote: > > > Hi Dan, > > > > > > On Fri, Mar 01, 2024 at 04:42:01PM +0300, Dan Carpenter wrote: > > > > Sakari Ailus pointed out in another thread that we could use __free() > > > > instead. Something like this: > > > > > > > > > > Looks good to me. > > > > Thanks for checking! I've never used these before. > > > > > > > > We could merge this with your SoB (pending Niklas's review). :-) The driver > > > has been since moved under drivers/media/platform/renesas/rcar-vin/ . > > > > Alright. I can resend this as a proper patch. > > Please do. > > I do find the idea of scoped operations and the syntax > > struct fwnode_handle *fwnode __free(fwnode_handle) = NULL; > > a bit foreign in a C context. But I think the intention is clear and it > allows us to avoid having the remember to free the fwnode in error paths > which is a nice thing. > I said I would send a couple of these but then Markus went ahead and sent the patches that I was going to write... And then it was like, "Oh, these have some questionable style issues" so it wasn't clear what was happening and I lost track. regards, dan carpenter
