Re: [PATCH] SoC Camera: ov6650: minor cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Monday 08 November 2010 22:20:33 Guennadi Liakhovetski wrote:
> On Tue, 2 Nov 2010, Janusz Krzysztofik wrote:
> > This is a followup patch that addresses two minor issues left in the
> > recently added ov6650 sensor driver, as I've promised to the subsystem
> > maintainer:
> > - remove a pair of extra brackets, 
> > - drop useless case for not possible v4l2_mbus_pixelcode enum value of 0.
> >
> > Created against linux-2.6.37-rc1.
> >
> > Signed-off-by: Janusz Krzysztofik <jkrzyszt@xxxxxxxxxxxx>
>
> Applied together with other your 3 patches and pushed for 2.6.37-rc2.

Hi Guennadi,
Thanks for taking my fixes.

Thursday 30 September 2010 13:35:49 Janusz Krzysztofik wrote:
> There are still two SG mode specific corner cases to be corrected,
> previously not detected because of poor sensor driver functionality: 1)
> frame size not exceeding one page, resulting in "unexpected end of frame"
> message and capture restart every frame, and 2) last sgbuf lenght less than
> bytes_per_line, resulting in unstable picture. I'm going to address those
> two with fixes.

Since both issues don't affect typical usage (one of standard resolutions) and 
both are videobuf-sg related, I'm wondering if I should better wait for 
videobuf2 and try to port my driver instead of making things still more 
complicated than they already are. What do you think?

Thanks,
Janusz
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux