Re: [PATCH] SoC Camera: ov6650: minor cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Janusz

On Tue, 2 Nov 2010, Janusz Krzysztofik wrote:

> This is a followup patch that addresses two minor issues left in the recently 
> added ov6650 sensor driver, as I've promised to the subsystem maintainer:
> - remove a pair of extra brackets,
> - drop useless case for not possible v4l2_mbus_pixelcode enum value of 0.
> 
> Created against linux-2.6.37-rc1.
> 
> Signed-off-by: Janusz Krzysztofik <jkrzyszt@xxxxxxxxxxxx>

Applied together with other your 3 patches and pushed for 2.6.37-rc2.

Thanks
Guennadi

> ---
> 
>  drivers/media/video/ov6650.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> --- linux-2.6.37-rc1/drivers/media/video/ov6650.c.orig	2010-11-01 22:41:59.000000000 +0100
> +++ linux-2.6.37-rc1/drivers/media/video/ov6650.c	2010-11-02 16:56:49.000000000 +0100
> @@ -754,7 +754,7 @@ static int ov6650_g_fmt(struct v4l2_subd
>  
>  static bool is_unscaled_ok(int width, int height, struct v4l2_rect *rect)
>  {
> -	return (width > rect->width >> 1 || height > rect->height >> 1);
> +	return width > rect->width >> 1 || height > rect->height >> 1;
>  }
>  
>  static u8 to_clkrc(struct v4l2_fract *timeperframe,
> @@ -840,8 +840,6 @@ static int ov6650_s_fmt(struct v4l2_subd
>  		coma_mask |= COMA_BW | COMA_BYTE_SWAP | COMA_WORD_SWAP;
>  		coma_set |= COMA_RAW_RGB | COMA_RGB;
>  		break;
> -	case 0:
> -		break;
>  	default:
>  		dev_err(&client->dev, "Pixel format not handled: 0x%x\n", code);
>  		return -EINVAL;
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux