On Tue, Mar 05, 2024 at 10:21:54AM +0000, Sakari Ailus wrote: > Hi Laurent, > > On Wed, Feb 07, 2024 at 04:24:35PM +0200, Laurent Pinchart wrote: > > Hi Sakari, > > > > Thank you for the patch. > > > > On Wed, Dec 20, 2023 at 12:37:04PM +0200, Sakari Ailus wrote: > > > v4l2_device_unregister() unregisters V4L2 sub-device nodes among other > > > things. Call it before releasing memory and other resources. > > > > Please expand the commit message, it's not immediately clear why this is > > needed and what the consequences are. > > Thanks for the review. > > There's actually a change in APIs here as the async notifier expects the > V4L2 device to remain in place so the notifier can't be cleaned up before > unregistering the V4L2 device. Further patches in the set move cleaning up > the notifier to the release callback but I think it can well be done here, > too. So I think this patch can be dropped. That went a bit too fast. The call should be moved after the notifier cleanup. -- Sakari Ailus
