Hi Sakari, Thank you for the patch. On Wed, Dec 20, 2023 at 12:37:04PM +0200, Sakari Ailus wrote: > v4l2_device_unregister() unregisters V4L2 sub-device nodes among other > things. Call it before releasing memory and other resources. Please expand the commit message, it's not immediately clear why this is needed and what the consequences are. > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > Acked-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx> > --- > drivers/media/pci/intel/ipu3/ipu3-cio2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2.c > index 5d3b0ffd3d08..da82d09b46ab 100644 > --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c > +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c > @@ -1827,11 +1827,11 @@ static void cio2_pci_remove(struct pci_dev *pci_dev) > struct cio2_device *cio2 = pci_get_drvdata(pci_dev); > > media_device_unregister(&cio2->media_dev); > + v4l2_device_unregister(&cio2->v4l2_dev); > v4l2_async_nf_unregister(&cio2->notifier); > v4l2_async_nf_cleanup(&cio2->notifier); > cio2_queues_exit(cio2); > cio2_fbpt_exit_dummy(cio2); > - v4l2_device_unregister(&cio2->v4l2_dev); > media_device_cleanup(&cio2->media_dev); > mutex_destroy(&cio2->lock); > -- Regards, Laurent Pinchart
