On Wednesday 10 November 2010, Jimmy Rubin wrote: > + > + if (ddev->id == PRIMARY_DISPLAY_ID && rotate_main) { > + swap(width, height); > +#ifdef CONFIG_DISPLAY_GENERIC_DSI_PRIMARY_ROTATE_180_DEGREES > + rotate = FB_ROTATE_CCW; > +#else > + rotate = FB_ROTATE_CW; > +#endif > + } > + > + virtual_width = width; > + virtual_height = height * 2; > +#ifdef CONFIG_DISPLAY_GENERIC_DSI_PRIMARY_AUTO_SYNC > + if (ddev->id == PRIMARY_DISPLAY_ID) > + virtual_height = height; > +#endif > + The contents of the hardware description should really not be configuration dependent, because that breaks booting the same kernel on machines that have different requirements. This is something that should be passed down from the boot loader. > +static void mcde_epod_enable(void) > +{ > + /* Power on DSS mem */ > + writel(PRCMU_ENABLE_DSS_MEM, PRCM_EPOD_C_SET); > + mdelay(PRCMU_MCDE_DELAY); > + /* Power on DSS logic */ > + writel(PRCMU_ENABLE_DSS_LOGIC, PRCM_EPOD_C_SET); > + mdelay(PRCMU_MCDE_DELAY); > +} In general, try to avoid using mdelay. Keeping the CPU busy for miliseconds or even microseconds for no reason is just wrong. Reasonable hardware will not require this and do the right thing anyway. multiple writel calls are by design strictly ordered on the bus. If that is not the case on your hardware, you should find a proper way to ensure ordering and create a small wrapper for it with a comment that explains the breakage. Better get the hardware designers to fix their crap before releasing a product ;-) If there is not even a way to reorder I/O by accessing other registers, use msleep() to let the CPU do something useful in the meantime and complain even more to the HW people. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html