On 16/02/2024 10:49, Shreeya Patel wrote: > Export hdmirx_biu soft reset id which is required by the hdmirx controller. > > Signed-off-by: Shreeya Patel <shreeya.patel@xxxxxxxxxxxxx> > --- > drivers/clk/rockchip/rst-rk3588.c | 1 + > include/dt-bindings/reset/rockchip,rk3588-cru.h | 2 ++ Please run scripts/checkpatch.pl and fix reported warnings. Some warnings can be ignored, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. Please do internal review. The internal Collabora review would tell you: YOU MUST run checkpatch. Then you see errors, so why do you send patch with errors to the mailing list? Best regards, Krzysztof
