Re: [PATCH 1/2] media: i2c: ov5645: Move the register 0x3008 from ov5645_global_init_setting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Biju,

> I think it is different here. That 1 msec is delay associated with
> applying hardware power see [1]

Okay, ack.

> I will restore it.

Thanks!

I had meanwhile another thought. What if we kind of merge the two
patches, so the outcome is basically this:

In ov5645_set_register_array:

	If (settings->reg == 0x3008 && settings->val == 0x82)
		usleep_range(1000, 2000)

?

Then, we don't need to split the array and we are also future proof if
we ever need to set the reset bit again somewhere else.

Bonus points for replacing 0x82 with a define :)

What do you think?

Happy hacking,

   Wolfram

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux