Testing OV5645 with i2c bus frequency @400kHz on RZ/G2L SMARC EVL platform
shows issues like the captured image is either greenish or it is not
capturing the image at all. However, It is working ok when the i2c
frequency is 100kHz. From this, it is clear that we have a timing issue
at high speed. The testing also shows that if we add a delay >= 1 msec
after register write {0x3008, 0x82}, then the captured image is always
good. So, move the register 0x3008 and 0x3103 from ov5645_*_init_setting
to a new table ov5645_global_init_setting.
Drop the unnecessary entry { 0x3008, 0x42 } from ov5645_*init_setting
table at the start.
Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
---
drivers/media/i2c/ov5645.c | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c
index a26ac11c989d..a5cc959d535e 100644
--- a/drivers/media/i2c/ov5645.c
+++ b/drivers/media/i2c/ov5645.c
@@ -116,10 +116,12 @@ static inline struct ov5645 *to_ov5645(struct v4l2_subdev *sd)
return container_of(sd, struct ov5645, sd);
}
-static const struct reg_value ov5645_global_init_setting[] = {
+static const struct reg_value ov5645_global_reset_setting[] = {
{ 0x3103, 0x11 },
- { 0x3008, 0x82 },
- { 0x3008, 0x42 },
+ { 0x3008, 0x82 }
+};
+
+static const struct reg_value ov5645_global_init_setting[] = {
{ 0x3103, 0x03 },
{ 0x3503, 0x07 },
{ 0x3002, 0x1c },
@@ -671,6 +673,15 @@ static int ov5645_set_power_on(struct device *dev)
msleep(20);
+ ret = ov5645_set_register_array(ov5645, ov5645_global_reset_setting,
+ ARRAY_SIZE(ov5645_global_reset_setting));
+ if (ret < 0) {
+ dev_err(ov5645->dev, "could not reset\n");
+ goto exit;
+ }
+
+ usleep_range(1000, 2000);
+
ret = ov5645_set_register_array(ov5645, ov5645_global_init_setting,
ARRAY_SIZE(ov5645_global_init_setting));
if (ret < 0) {
--
2.25.1
