On Thu, Feb 01, 2024 at 06:33:13PM +0900, Sergey Senozhatsky wrote:
> On (24/02/01 09:22), Sakari Ailus wrote:
> > Hi Sergey,
> >
> > Thanks for the review.
>
> Hi Sakari,
>
> > On Thu, Feb 01, 2024 at 06:17:13PM +0900, Sergey Senozhatsky wrote:
> > > On (23/10/02 13:55), Sakari Ailus wrote:
> [..]
> > > > @@ -197,6 +197,7 @@ int media_entity_pads_init(struct media_entity *entity, u16 num_pads,
> > > > struct media_device *mdev = entity->graph_obj.mdev;
> > > > struct media_pad *iter;
> > > > unsigned int i = 0;
> > > > + int ret = 0;
> > > >
> > > > if (num_pads >= MEDIA_ENTITY_MAX_PADS)
> > > > return -E2BIG;
> > > > @@ -210,15 +211,27 @@ int media_entity_pads_init(struct media_entity *entity, u16 num_pads,
> > > > media_entity_for_each_pad(entity, iter) {
> > > > iter->entity = entity;
> > > > iter->index = i++;
> > > > +
> > > > + if (hweight32(iter->flags & (MEDIA_PAD_FL_SINK |
> > > > + MEDIA_PAD_FL_SOURCE)) != 1) {
> > > > + ret = -EINVAL;
> > >
> > > Can we please have some sort of WARN_ON() or pr_err() here?
> > > This is a pretty big change.
> >
> > Doing proper input validation is hardly anything unusual, is it?
>
> Well, function requirements change quite significantly, to the point
> that drivers that worked before won't work after.
>
> > I'm fine with a WARN_ON() though, I'll add that to v8.
>
> Thanks!
Actually this was a patchset that was merged quite some time ago. I'll
post separate patch on this.
--
Sakari Ailus
