Hi Sergey,
Thanks for the review.
On Thu, Feb 01, 2024 at 06:17:13PM +0900, Sergey Senozhatsky wrote:
> On (23/10/02 13:55), Sakari Ailus wrote:
> >
> > Check the validity of pad flags on entity init. Exactly one of the flags
> > must be set.
> >
> > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > ---
> > drivers/media/mc/mc-entity.c | 15 ++++++++++++++-
> > 1 file changed, 14 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c
> > index 83468d4a440b..543a392f8635 100644
> > --- a/drivers/media/mc/mc-entity.c
> > +++ b/drivers/media/mc/mc-entity.c
> > @@ -197,6 +197,7 @@ int media_entity_pads_init(struct media_entity *entity, u16 num_pads,
> > struct media_device *mdev = entity->graph_obj.mdev;
> > struct media_pad *iter;
> > unsigned int i = 0;
> > + int ret = 0;
> >
> > if (num_pads >= MEDIA_ENTITY_MAX_PADS)
> > return -E2BIG;
> > @@ -210,15 +211,27 @@ int media_entity_pads_init(struct media_entity *entity, u16 num_pads,
> > media_entity_for_each_pad(entity, iter) {
> > iter->entity = entity;
> > iter->index = i++;
> > +
> > + if (hweight32(iter->flags & (MEDIA_PAD_FL_SINK |
> > + MEDIA_PAD_FL_SOURCE)) != 1) {
> > + ret = -EINVAL;
>
> Can we please have some sort of WARN_ON() or pr_err() here?
> This is a pretty big change.
Doing proper input validation is hardly anything unusual, is it?
I'm fine with a WARN_ON() though, I'll add that to v8.
--
Regards,
Sakari Ailus
