Re: [PATCH 6/6] media: venus: core: Add SC8280XP resource struct

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/08/2023 21:09, Konrad Dybcio wrote:
Add SC8280XP configuration data and related compatible.

Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
---
  drivers/media/platform/qcom/venus/core.c | 45 ++++++++++++++++++++++++++++++++
  1 file changed, 45 insertions(+)

diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
index 5f285ae75e9d..32591b624a36 100644
--- a/drivers/media/platform/qcom/venus/core.c
+++ b/drivers/media/platform/qcom/venus/core.c

Reviewing this series, I think my input here has not been helpful or correct.

1. Declaring encoders/decoders in dts or yaml is wrong, accepted.

2. We can make a platform choice to hard-code that here in the
   platform declarations.

3. Remove the requirement from yaml for sc8280xp to declare decoder
   encoder

3. Profit.

Existing dtb all, literally all do the same thing first block decoder, second block encoder.

Rather than perform extensive surgery to venus to remediate the original yaml sin - hard-code decoder/encoder into platform code and deprecate the legacy over time.

Yes that means fixing to block 0 as decoder and block 1 as encoder but that is the defacto situation we have now, we may as well make it dejure.

---
bod




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux