Re: [PATCH 1/2] dt-bindings: media: mediatek-jpeg-encoder: change max ioomus count

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 15/01/2024 04:57, Eugen Hristev wrote:
On 1/9/24 05:27, Rob Herring wrote:
On Wed, Dec 27, 2023 at 03:08:11PM +0200, Eugen Hristev wrote:
MT8186 has 4 iommus in the list, to cope with this situation, adjust
the maxItems to 4 (instead of previous 2).
Add also minItems as 1 since iommus are mandatory, to avoid warning
on the example.

maxItems alone means minItems is the same size. If IOMMU is required,
then 'required' is where that is defined. Is there a case where 1 IOMMU
is valid? If so, what h/w has this case.

Rob



Hello Rob,

Without setting a minItems , the example in the binding fails, because it has just
2 items, while the maxItems is now 4.
I set minItems as 1 to avoid restricting any kind of hardware to have at least 2
items, but if you claim that previously, maxItems=minItems=2 , I will change this to 2.
Is that fine with you ?


I think that's what you should do yes. If in the future there shows up a platform with just one iommu, then we can fix that.

Regards,
Matthias




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux