On Tue, 2 Nov 2010 17:12:14 -0400, Jarod Wilson <jarod@xxxxxxxxxx> wrote:
> On Fri, Oct 29, 2010 at 09:21:21PM +0200, David HÃrdeman wrote:
>> I think the driver could be further simplified by using
>> ir_raw_event_store_with_filter(), right?
>
> And in fact, it is. I've got a new series of patches redone atop your
> rc-core patch series that includes usage of _with_filter in mceusb.
>From a quick check, I think the entire PARSE_IRDATA block in
mceusb_process_ir_data() could be simplified to:
case PARSE_IRDATA:
ir->rem--;
rawir.pulse = !!(ir->buf_in[i] & MCE_PULSE_BIT);
rawir.duration = (ir->buf_in[i] & MCE_PULSE_MASK)
* MCE_TIME_UNIT * 1000;
ir_raw_event_store_with_filter(ir->rc, &rawir);
break;
And you can then remove "struct ir_raw_event rawir" from struct
mceusb_dev.
--
David HÃrdeman
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
