Re: [PATCH v2 3/4] media: i2c: add MAX96714 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/01/2024 14:20, Julien Massot wrote:
>>> +static int max96714_get_hw_resources(struct max96714_priv *priv)
>>> +{
>>> +	struct device *dev = &priv->client->dev;
>>> +
>>> +	priv->regmap = devm_regmap_init_i2c(priv->client,
>>> +					    &max96714_regmap_config);
>>> +	if (IS_ERR(priv->regmap))
>>> +		return PTR_ERR(priv->regmap);
>>> +
>>> +	priv->gpiod_pwdn = devm_gpiod_get_optional(&priv->client->dev, "enable",
>>> +						   GPIOD_OUT_HIGH);
>>> +	if (IS_ERR(priv->gpiod_pwdn))
>>> +		return dev_err_probe(dev, PTR_ERR(priv->gpiod_pwdn),
>>
>> A powerdown GPIO is not an enable GPIO. Please use correct name - see
>> gpio-consumers-common.yaml
> Ok I will rename it 'pwdn' instead.

Did you open that file and read it?

Best regards,
Krzysztof





[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux