Re: [PATCH v2 3/4] media: i2c: add MAX96714 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 12/8/23 18:18, Krzysztof Kozlowski wrote:
On 08/12/2023 15:33, Julien Massot wrote:
This driver handle the MAX96714 deserializer in tunnel mode.
The CSI output will replicate all the CSI traffic capture by
the remote serializer.

Signed-off-by: Julien Massot <julien.massot@xxxxxxxxxxxxx>

...

+static int max96714_get_hw_resources(struct max96714_priv *priv)
+{
+	struct device *dev = &priv->client->dev;
+
+	priv->regmap = devm_regmap_init_i2c(priv->client,
+					    &max96714_regmap_config);
+	if (IS_ERR(priv->regmap))
+		return PTR_ERR(priv->regmap);
+
+	priv->gpiod_pwdn = devm_gpiod_get_optional(&priv->client->dev, "enable",
+						   GPIOD_OUT_HIGH);
+	if (IS_ERR(priv->gpiod_pwdn))
+		return dev_err_probe(dev, PTR_ERR(priv->gpiod_pwdn),

A powerdown GPIO is not an enable GPIO. Please use correct name - see
gpio-consumers-common.yaml
Ok I will rename it 'pwdn' instead.
Thanks,

--
Julien Massot




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux