On Sat, Oct 02, 2010 at 10:03:55AM +0200, Guennadi Liakhovetski wrote: > Michael, any insight? long time ago... > > > > For the YUV and RGB formats, tested and acked. > > > > For the bayer, I don't use it. With row switch, that gives back: > > > > byte offset: 0 1 2 3 > > > > B G B G > > > > G R G R > > > > > > > > Without the switch: > > > > byte offset: 0 1 2 3 > > > > G R G R > > > > B G B G > > > > > > > > I would have expected the second version (ie. without the switch, ie. the > > > > original version of mt9m111 driver) to be correct, but I might be wrong. Maybe > > > > Michael can enlighten me here. > > > Yes this seems odd, i normaly expect the first line to be BGBG. > > > I will search for the cause and reply a little later, perhaps end of > > > the week, since i am also short on time at this moment. I have reviewed the Datasheet of the Camera and found Roberts previously described behaviour as correct. So the Bayercode seems functional in that patch. > > Ok, _if_ you have to redo this patch, maybe you could also merge > > > > [PATCH 04/11] mt9m111: added new bit offset defines > > [PATCH 08/11] mt9m111: added reg_mask function > > > > into it, otherwise their purpose is unclear. I will send a squashed Version of the three patches in some minutes. Cheers, Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
