Hi Robert and Guennadi On Sun, Aug 29, 2010 at 09:17:00PM +0200, Robert Jarzmik wrote: > Guennadi Liakhovetski <g.liakhovetski@xxxxxx> writes: > > > Robert, I'll need your ack / tested by on this one too. It actually > > changes behaviour, for example, it sets MT9M111_OUTFMT_FLIP_BAYER_ROW in > > the OUTPUT_FORMAT_CTRL register for the V4L2_MBUS_FMT_SBGGR8_1X8 8 bit > > Bayer format. Maybe other things too - please have a look. > > For the YUV and RGB formats, tested and acked. > For the bayer, I don't use it. With row switch, that gives back: > byte offset: 0 1 2 3 > B G B G > G R G R > > Without the switch: > byte offset: 0 1 2 3 > G R G R > B G B G > > I would have expected the second version (ie. without the switch, ie. the > original version of mt9m111 driver) to be correct, but I might be wrong. Maybe > Michael can enlighten me here. Yes this seems odd, i normaly expect the first line to be BGBG. I will search for the cause and reply a little later, perhaps end of the week, since i am also short on time at this moment. Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html