On Thu, Oct 26, 2023 at 05:50:48PM +0000, Sakari Ailus wrote: > On Thu, Oct 26, 2023 at 05:20:11PM +0300, Laurent Pinchart wrote: > > On Thu, Oct 26, 2023 at 07:40:52AM +0000, Sakari Ailus wrote: > > > On Thu, Oct 26, 2023 at 09:36:41AM +0200, Hans Verkuil wrote: > > > > On 26/10/2023 09:03, Sakari Ailus wrote: > > > > > Warn if the stream is set ot a non-zero value on sub-device pad state > > > > > access functions. A driver bug is required for triggering the warning. > > > > > > > > More confusion here: why not merge this into patch 2? > > > > > > I can squash it there. > > > > I'm fine with that, but I wonder if we need a WARN_ON() in that case. > > Won't driver developers notice the bug, given they'll get a NULL pointer > > ? > > Obviously they would. But it's also that the function shouldn't be called > that way: it's an obvious omission of input validation elsewhere and that > should be fixed. Yes, but won't the NULL pointer that the driver receive lead to the issue being fixed ? I expect a crash during development. -- Regards, Laurent Pinchart
