Re: [PATCH v4 9/9] media: v4l: subdev: Warn on stream when accessing stream-unaware data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 26, 2023 at 07:40:52AM +0000, Sakari Ailus wrote:
> On Thu, Oct 26, 2023 at 09:36:41AM +0200, Hans Verkuil wrote:
> > On 26/10/2023 09:03, Sakari Ailus wrote:
> > > Warn if the stream is set ot a non-zero value on sub-device pad state
> > > access functions. A driver bug is required for triggering the warning.
> > 
> > More confusion here: why not merge this into patch 2?
> 
> I can squash it there.

I'm fine with that, but I wonder if we need a WARN_ON() in that case.
Won't driver developers notice the bug, given they'll get a NULL pointer
?

-- 
Regards,

Laurent Pinchart



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux