Re: [PATCH v2 1/6] media: v4l: subdev: Also return pads array information on stream functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 23, 2023 at 08:29:38PM +0300, Laurent Pinchart wrote:
> On Mon, Oct 23, 2023 at 05:18:35PM +0000, Sakari Ailus wrote:
> > On Mon, Oct 23, 2023 at 08:09:53PM +0300, Laurent Pinchart wrote:
> > > On Mon, Oct 23, 2023 at 05:01:48PM +0000, Sakari Ailus wrote:
> > > > Hi Laurent,
> > > > 
> > > > On Mon, Oct 23, 2023 at 05:08:45PM +0300, Laurent Pinchart wrote:
> > > > > > > +		if (WARN_ON(pad >= state->sd->entity.num_pads))
> > > > > 
> > > > > There's no sd field in struct v4l2_subdev_state in the linux media
> > > > > master branch, no mention of dependencies in the cover letter, and no
> > > > > specified base.
> > > > > 
> > > > > Please generate patch series with --base.
> > > > 
> > > > That wouldn't help.
> > > 
> > > Why not ?
> > 
> > Because the patch the rest of the set depends on is missing. The base for
> > the patches is indeed the media stage tree (or close to that).
> 
> The cover letter will then mention that. Try it out :-)

I can use it in v3 but that alone will not solve the problem. :-)

-- 
Sakari Ailus



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux