Hi Laurent, On Mon, Oct 23, 2023 at 04:29:02PM +0300, Laurent Pinchart wrote: > > + return NULL; > > + > > + if (state->pads) { > > + if (stream) > > + return NULL; > > + > > + if (WARN_ON(pad >= state->sd->entity.num_pads)) > > + pad = 0; > > + > > + return &state->pads[pad].try_fmt; > > + } > > + > > lockdep_assert_held(state->lock); > > Can we move towards proper locking for all callers ? This was never done in the existing pad ops. That's certainly a good idea, but it belongs to a new patch. I'll add one. -- Regards, Sakari Ailus