Re: [PATCH 3/6] media: v4l: subdev: Rename sub-device state information access functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sakari,

kernel test robot noticed the following build warnings:

[auto build test WARNING on next-20231016]
[also build test WARNING on linus/master v6.6-rc6]
[cannot apply to media-tree/master rockchip/for-next sailus-media-tree/streams v6.6-rc6 v6.6-rc5 v6.6-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sakari-Ailus/media-v4l-subdev-Also-return-pads-array-information-on-stream-functions/20231017-120800
base:   next-20231016
patch link:    https://lore.kernel.org/r/20231013104424.404768-4-sakari.ailus%40linux.intel.com
patch subject: [PATCH 3/6] media: v4l: subdev: Rename sub-device state information access functions
config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20231017/202310171645.8Tac7Ez4-lkp@xxxxxxxxx/config)
compiler: sparc64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231017/202310171645.8Tac7Ez4-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310171645.8Tac7Ez4-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

   drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c: In function 'mxc_isi_crossbar_gasket_enable':
   drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c:61:15: error: implicit declaration of function 'v4l2_subdev_state_get_stream_format'; did you mean 'v4l2_subdev_state_get_opposite_stream_format'? [-Werror=implicit-function-declaration]
      61 |         fmt = v4l2_subdev_state_get_stream_format(state, port, 0);
         |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |               v4l2_subdev_state_get_opposite_stream_format
>> drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c:61:13: warning: assignment to 'const struct v4l2_mbus_framefmt *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
      61 |         fmt = v4l2_subdev_state_get_stream_format(state, port, 0);
         |             ^
   drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c: In function 'mxc_isi_crossbar_set_fmt':
>> drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c:284:18: warning: assignment to 'struct v4l2_mbus_framefmt *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     284 |         sink_fmt = v4l2_subdev_state_get_stream_format(state, fmt->pad,
         |                  ^
   drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c:299:28: warning: assignment to 'struct v4l2_mbus_framefmt *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     299 |                 source_fmt = v4l2_subdev_state_get_stream_format(state, route->source_pad,
         |                            ^
   cc1: some warnings being treated as errors


vim +61 drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c

cf21f328fcafac Laurent Pinchart 2019-01-21  26  
cf21f328fcafac Laurent Pinchart 2019-01-21  27  static int mxc_isi_crossbar_gasket_enable(struct mxc_isi_crossbar *xbar,
cf21f328fcafac Laurent Pinchart 2019-01-21  28  					  struct v4l2_subdev_state *state,
cf21f328fcafac Laurent Pinchart 2019-01-21  29  					  struct v4l2_subdev *remote_sd,
cf21f328fcafac Laurent Pinchart 2019-01-21  30  					  u32 remote_pad, unsigned int port)
cf21f328fcafac Laurent Pinchart 2019-01-21  31  {
cf21f328fcafac Laurent Pinchart 2019-01-21  32  	struct mxc_isi_dev *isi = xbar->isi;
f48498ad0a4106 Guoniu.zhou      2023-06-29  33  	const struct mxc_gasket_ops *gasket_ops = isi->pdata->gasket_ops;
cf21f328fcafac Laurent Pinchart 2019-01-21  34  	const struct v4l2_mbus_framefmt *fmt;
cf21f328fcafac Laurent Pinchart 2019-01-21  35  	struct v4l2_mbus_frame_desc fd;
cf21f328fcafac Laurent Pinchart 2019-01-21  36  	int ret;
cf21f328fcafac Laurent Pinchart 2019-01-21  37  
f48498ad0a4106 Guoniu.zhou      2023-06-29  38  	if (!gasket_ops)
cf21f328fcafac Laurent Pinchart 2019-01-21  39  		return 0;
cf21f328fcafac Laurent Pinchart 2019-01-21  40  
cf21f328fcafac Laurent Pinchart 2019-01-21  41  	/*
cf21f328fcafac Laurent Pinchart 2019-01-21  42  	 * Configure and enable the gasket with the frame size and CSI-2 data
cf21f328fcafac Laurent Pinchart 2019-01-21  43  	 * type. For YUV422 8-bit, enable dual component mode unconditionally,
cf21f328fcafac Laurent Pinchart 2019-01-21  44  	 * to match the configuration of the CSIS.
cf21f328fcafac Laurent Pinchart 2019-01-21  45  	 */
cf21f328fcafac Laurent Pinchart 2019-01-21  46  
cf21f328fcafac Laurent Pinchart 2019-01-21  47  	ret = v4l2_subdev_call(remote_sd, pad, get_frame_desc, remote_pad, &fd);
cf21f328fcafac Laurent Pinchart 2019-01-21  48  	if (ret) {
cf21f328fcafac Laurent Pinchart 2019-01-21  49  		dev_err(isi->dev,
cf21f328fcafac Laurent Pinchart 2019-01-21  50  			"failed to get frame descriptor from '%s':%u: %d\n",
cf21f328fcafac Laurent Pinchart 2019-01-21  51  			remote_sd->name, remote_pad, ret);
cf21f328fcafac Laurent Pinchart 2019-01-21  52  		return ret;
cf21f328fcafac Laurent Pinchart 2019-01-21  53  	}
cf21f328fcafac Laurent Pinchart 2019-01-21  54  
cf21f328fcafac Laurent Pinchart 2019-01-21  55  	if (fd.num_entries != 1) {
cf21f328fcafac Laurent Pinchart 2019-01-21  56  		dev_err(isi->dev, "invalid frame descriptor for '%s':%u\n",
cf21f328fcafac Laurent Pinchart 2019-01-21  57  			remote_sd->name, remote_pad);
cf21f328fcafac Laurent Pinchart 2019-01-21  58  		return -EINVAL;
cf21f328fcafac Laurent Pinchart 2019-01-21  59  	}
cf21f328fcafac Laurent Pinchart 2019-01-21  60  
cf21f328fcafac Laurent Pinchart 2019-01-21 @61  	fmt = v4l2_subdev_state_get_stream_format(state, port, 0);
cf21f328fcafac Laurent Pinchart 2019-01-21  62  	if (!fmt)
cf21f328fcafac Laurent Pinchart 2019-01-21  63  		return -EINVAL;
cf21f328fcafac Laurent Pinchart 2019-01-21  64  
f48498ad0a4106 Guoniu.zhou      2023-06-29  65  	gasket_ops->enable(isi, &fd, fmt, port);
cf21f328fcafac Laurent Pinchart 2019-01-21  66  	return 0;
cf21f328fcafac Laurent Pinchart 2019-01-21  67  }
cf21f328fcafac Laurent Pinchart 2019-01-21  68  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux