Hi Sakari, kernel test robot noticed the following build warnings: [auto build test WARNING on next-20231016] [also build test WARNING on linus/master v6.6-rc6] [cannot apply to media-tree/master rockchip/for-next sailus-media-tree/streams v6.6-rc6 v6.6-rc5 v6.6-rc4] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Sakari-Ailus/media-v4l-subdev-Also-return-pads-array-information-on-stream-functions/20231017-120800 base: next-20231016 patch link: https://lore.kernel.org/r/20231013104424.404768-4-sakari.ailus%40linux.intel.com patch subject: [PATCH 3/6] media: v4l: subdev: Rename sub-device state information access functions config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231017/202310171359.UuOwm2bc-lkp@xxxxxxxxx/config) compiler: m68k-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231017/202310171359.UuOwm2bc-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202310171359.UuOwm2bc-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): drivers/media/i2c/ds90ub913.c: In function 'ub913_set_fmt': drivers/media/i2c/ds90ub913.c:427:15: error: implicit declaration of function 'v4l2_subdev_state_get_stream_format'; did you mean 'v4l2_subdev_state_get_opposite_stream_format'? [-Werror=implicit-function-declaration] 427 | fmt = v4l2_subdev_state_get_stream_format(state, format->pad, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | v4l2_subdev_state_get_opposite_stream_format >> drivers/media/i2c/ds90ub913.c:427:13: warning: assignment to 'struct v4l2_mbus_framefmt *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 427 | fmt = v4l2_subdev_state_get_stream_format(state, format->pad, | ^ cc1: some warnings being treated as errors -- drivers/media/i2c/ds90ub953.c: In function 'ub953_set_fmt': drivers/media/i2c/ds90ub953.c:561:15: error: implicit declaration of function 'v4l2_subdev_state_get_stream_format'; did you mean 'v4l2_subdev_state_get_opposite_stream_format'? [-Werror=implicit-function-declaration] 561 | fmt = v4l2_subdev_state_get_stream_format(state, format->pad, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | v4l2_subdev_state_get_opposite_stream_format >> drivers/media/i2c/ds90ub953.c:561:13: warning: assignment to 'struct v4l2_mbus_framefmt *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 561 | fmt = v4l2_subdev_state_get_stream_format(state, format->pad, | ^ cc1: some warnings being treated as errors -- drivers/media/i2c/ds90ub960.c: In function 'ub960_configure_ports_for_streaming': drivers/media/i2c/ds90ub960.c:2454:23: error: implicit declaration of function 'v4l2_subdev_state_get_stream_format'; did you mean 'v4l2_subdev_state_get_opposite_stream_format'? [-Werror=implicit-function-declaration] 2454 | fmt = v4l2_subdev_state_get_stream_format(state, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | v4l2_subdev_state_get_opposite_stream_format >> drivers/media/i2c/ds90ub960.c:2454:21: warning: assignment to 'struct v4l2_mbus_framefmt *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 2454 | fmt = v4l2_subdev_state_get_stream_format(state, | ^ drivers/media/i2c/ds90ub960.c: In function 'ub960_get_frame_desc': drivers/media/i2c/ds90ub960.c:2845:29: warning: assignment to 'struct v4l2_mbus_framefmt *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 2845 | fmt = v4l2_subdev_state_get_stream_format(state, pad, | ^ drivers/media/i2c/ds90ub960.c: In function 'ub960_set_fmt': drivers/media/i2c/ds90ub960.c:2894:13: warning: assignment to 'struct v4l2_mbus_framefmt *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 2894 | fmt = v4l2_subdev_state_get_stream_format(state, format->pad, | ^ cc1: some warnings being treated as errors vim +427 drivers/media/i2c/ds90ub913.c c158d0d4ff1530 Tomi Valkeinen 2023-06-19 403 c158d0d4ff1530 Tomi Valkeinen 2023-06-19 404 static int ub913_set_fmt(struct v4l2_subdev *sd, c158d0d4ff1530 Tomi Valkeinen 2023-06-19 405 struct v4l2_subdev_state *state, c158d0d4ff1530 Tomi Valkeinen 2023-06-19 406 struct v4l2_subdev_format *format) c158d0d4ff1530 Tomi Valkeinen 2023-06-19 407 { c158d0d4ff1530 Tomi Valkeinen 2023-06-19 408 struct ub913_data *priv = sd_to_ub913(sd); c158d0d4ff1530 Tomi Valkeinen 2023-06-19 409 struct v4l2_mbus_framefmt *fmt; c158d0d4ff1530 Tomi Valkeinen 2023-06-19 410 const struct ub913_format_info *finfo; c158d0d4ff1530 Tomi Valkeinen 2023-06-19 411 c158d0d4ff1530 Tomi Valkeinen 2023-06-19 412 if (format->which == V4L2_SUBDEV_FORMAT_ACTIVE && c158d0d4ff1530 Tomi Valkeinen 2023-06-19 413 priv->enabled_source_streams) c158d0d4ff1530 Tomi Valkeinen 2023-06-19 414 return -EBUSY; c158d0d4ff1530 Tomi Valkeinen 2023-06-19 415 c158d0d4ff1530 Tomi Valkeinen 2023-06-19 416 /* Source format is fully defined by the sink format, so not settable */ c158d0d4ff1530 Tomi Valkeinen 2023-06-19 417 if (format->pad == UB913_PAD_SOURCE) c158d0d4ff1530 Tomi Valkeinen 2023-06-19 418 return v4l2_subdev_get_fmt(sd, state, format); c158d0d4ff1530 Tomi Valkeinen 2023-06-19 419 c158d0d4ff1530 Tomi Valkeinen 2023-06-19 420 finfo = ub913_find_format(format->format.code); c158d0d4ff1530 Tomi Valkeinen 2023-06-19 421 if (!finfo) { c158d0d4ff1530 Tomi Valkeinen 2023-06-19 422 finfo = &ub913_formats[0]; c158d0d4ff1530 Tomi Valkeinen 2023-06-19 423 format->format.code = finfo->incode; c158d0d4ff1530 Tomi Valkeinen 2023-06-19 424 } c158d0d4ff1530 Tomi Valkeinen 2023-06-19 425 c158d0d4ff1530 Tomi Valkeinen 2023-06-19 426 /* Set sink format */ c158d0d4ff1530 Tomi Valkeinen 2023-06-19 @427 fmt = v4l2_subdev_state_get_stream_format(state, format->pad, c158d0d4ff1530 Tomi Valkeinen 2023-06-19 428 format->stream); c158d0d4ff1530 Tomi Valkeinen 2023-06-19 429 if (!fmt) c158d0d4ff1530 Tomi Valkeinen 2023-06-19 430 return -EINVAL; c158d0d4ff1530 Tomi Valkeinen 2023-06-19 431 c158d0d4ff1530 Tomi Valkeinen 2023-06-19 432 *fmt = format->format; c158d0d4ff1530 Tomi Valkeinen 2023-06-19 433 c158d0d4ff1530 Tomi Valkeinen 2023-06-19 434 /* Propagate to source format, and adjust the mbus code */ c158d0d4ff1530 Tomi Valkeinen 2023-06-19 435 fmt = v4l2_subdev_state_get_opposite_stream_format(state, format->pad, c158d0d4ff1530 Tomi Valkeinen 2023-06-19 436 format->stream); c158d0d4ff1530 Tomi Valkeinen 2023-06-19 437 if (!fmt) c158d0d4ff1530 Tomi Valkeinen 2023-06-19 438 return -EINVAL; c158d0d4ff1530 Tomi Valkeinen 2023-06-19 439 c158d0d4ff1530 Tomi Valkeinen 2023-06-19 440 format->format.code = finfo->outcode; c158d0d4ff1530 Tomi Valkeinen 2023-06-19 441 c158d0d4ff1530 Tomi Valkeinen 2023-06-19 442 *fmt = format->format; c158d0d4ff1530 Tomi Valkeinen 2023-06-19 443 c158d0d4ff1530 Tomi Valkeinen 2023-06-19 444 return 0; c158d0d4ff1530 Tomi Valkeinen 2023-06-19 445 } c158d0d4ff1530 Tomi Valkeinen 2023-06-19 446 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
