Hi Laurent, On Fri, Oct 13, 2023 at 02:07:41PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Fri, Oct 13, 2023 at 01:44:20PM +0300, Sakari Ailus wrote: > > There are two sets of functions that return information from sub-device > > state, one for stream-unaware users and another for stream-aware users. > > Add support for stream-aware functions to return format, crop and compose > > information from pad-based array that are functionally equivalent to the > > old, stream-unaware ones. > > > > Also check state is non-NULL, in order to guard against old drivers > > potentially calling this with NULL state for active formats or selection > > rectangles. > > I'm not too keen on this I'm afraid :-( I think it gets confusing for > drivers that are not stream-aware to have to call a function that takes > a stream number. I don't see a problem with keeping two different sets > of functions, one for stream-aware drivers, and one for other drivers. This becomes a nuisance in drivers such as CCS that work with sub-devices some of which have streams and others which don't. I don't see why we should have two sets of functions to access the same information, even though it's stored differently. I can add a wrapper using C11 _Generic to make the stream number go away. -- Regards, Sakari Ailus
