Hi Laurent, On Fri, Oct 13, 2023 at 02:04:39PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Fri, Oct 13, 2023 at 01:44:21PM +0300, Sakari Ailus wrote: > > Rename the sub-devices state information access functions, removing > > "_state" and "_stream" from them. This makes them shorter and so more > > convenient to use. No other functions will be needed to access this > > information. > > The new names are too generic, and thus confusing. For instance, > v4l2_subdev_get_format() is way too close to v4l2_subdev_get_fmt(). I'm > fine dropping "_stream", but I would like to keep "_state". > My intention was actually to rename v4l2_subdev_get_fmt() later on: it's used in an ops struct, almost uniquely, so its name can be longer without it being a nuisance. I can include this in the same set. The reason for using a shorter names such as v4l2_subdev_get_format() is that they're nicer to use in the code. The function names we've added recently are often exceedingly long. There's hardly room for confusion in this case either: these functions will remain as the only interface to access information in sub-device state. -- Regards, Sakari Ailus
