Hi Hans, On Tue, Oct 10, 2023 at 10:06:38AM +0200, Hans Verkuil wrote: > On 10/10/23 09:59, Sakari Ailus wrote: > > Hi Hans, > > > > On Tue, Oct 10, 2023 at 09:24:10AM +0200, Hans Verkuil wrote: > >> Hi Laurent, > >> > >> On 06/10/2023 17:18, Laurent Pinchart wrote: > >>> Hi Hans, > >>> > >>> Thank you for the patch. > >>> > >>> On Fri, Oct 06, 2023 at 12:08:49PM +0200, Hans Verkuil wrote: > >>>> In two places the probe function returns instead of going > >>>> to the correct goto label. > >>>> > >>>> This fixes this smatch warning: > >>>> > >>>> drivers/media/i2c/mt9m114.c:2381 mt9m114_probe() warn: missing unwind goto? > >>>> > >>>> Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx> > >>>> CC: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > >>> > >>> I've already submitted > >>> https://lore.kernel.org/linux-media/20231003192043.27690-1-laurent.pinchart@xxxxxxxxxxxxxxxx > >> > >> Is it OK if I pick up your patch for this issue? I plan to pick up at least part > >> of this series tomorrow in order to cut down on the number of reported smatch > >> warnings. > > > > I've got it in my tree and I intend to send a PR by tomorrow (there's an > > issue also in the CCS driver). > > > > OK, then I leave this to you, Sakari. > > The two patches you reviewed (2/9 and 7/9), can I commit those or do you plan > to make those part of your PR? I don't care either way, as long as we don't > duplicate work... You already have them as part of your set so please take them. I think I've already reviewed them, too. -- Regards, Sakari Ailus
