This series fixes various smatch warnings. The build scripts didn't call smatch with the -p=kernel option, so some warnings were disabled. After fixing that new warnings appeared that are fixed in this series. A few warnings remain for false positives that would be very painful to fix, and those are filtered by the build script so that they don't pollute the output. Note that the adp1653 patch is a v2 of the first attempt: https://patchwork.linuxtv.org/project/linux-media/patch/da55b552-08ce-6bbe-c70b-eda6f53727f0@xxxxxxxxx/ I incorporated Sakari's suggestions in the v2. Regards, Hans Hans Verkuil (9): staging: media: atomisp: drop check for reentrant .s_stream() media: i2c: adp1653: don't reuse the same node pointer staging: media: atomisp: improve unwinding media: dvb-usb-v2: af9035: fix missing unlock media: nxp: imx-jpeg: use goto instead of return media: qcom: venus: fix incorrect return value media: i2c: tc358746: check fmt validity media: i2c: mt9m114: goto proper error path media: pci: mgb4: fix potential spectre vulnerability drivers/media/i2c/adp1653.c | 28 ++++++++++--------- drivers/media/i2c/mt9m114.c | 4 +-- drivers/media/i2c/tc358746.c | 6 +++- drivers/media/pci/mgb4/mgb4_sysfs_out.c | 5 +++- .../media/platform/nxp/imx-jpeg/mxc-jpeg.c | 2 +- .../media/platform/qcom/venus/pm_helpers.c | 2 +- drivers/media/usb/dvb-usb-v2/af9035.c | 13 ++++++--- .../media/atomisp/i2c/atomisp-gc0310.c | 6 ---- .../staging/media/atomisp/pci/atomisp_cmd.c | 18 ++++++++---- 9 files changed, 49 insertions(+), 35 deletions(-) -- 2.40.1