Hi Sakari, Thank you for the patch. On Wed, Sep 27, 2023 at 09:41:20AM +0300, Sakari Ailus wrote: > Add a definition for MIPI CSI-2 generic long packet types. The generic > long packet types are numbered from 1 to 4. > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > --- > include/media/mipi-csi2.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/media/mipi-csi2.h b/include/media/mipi-csi2.h > index c3d8f12234b1..1503c3fab1fe 100644 > --- a/include/media/mipi-csi2.h > +++ b/include/media/mipi-csi2.h > @@ -19,6 +19,7 @@ > #define MIPI_CSI2_DT_NULL 0x10 > #define MIPI_CSI2_DT_BLANKING 0x11 > #define MIPI_CSI2_DT_EMBEDDED_8B 0x12 > +#define MIPI_CSI2_DT_GENERIC_LONG(n) (0x12 + (n)) /* 1..4 */ I would write #define MIPI_CSI2_DT_GENERIC_LONG(n) (0x13 + (n) - 1) /* 1..4 */ to make it clear there's no overlap with MIPI_CSI2_DT_EMBEDDED_8B. Up to you. Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > #define MIPI_CSI2_DT_YUV420_8B 0x18 > #define MIPI_CSI2_DT_YUV420_10B 0x19 > #define MIPI_CSI2_DT_YUV420_8B_LEGACY 0x1a -- Regards, Laurent Pinchart
