On 26/09/2023 12:10, Ming Qian wrote: > There are total 4 slots available in the IP, and we only need to use one > slot in one os, assign a single slot, configure interrupt and power > domain only for 1 slot, not for the all 4 slots. > > Signed-off-by: Ming Qian <ming.qian@xxxxxxx> > --- > v4 > - improve commit message > - don't make an ABI break > v3 > - add vender prefix, change property slot to nxp,slot > - add type for property slot > > .../bindings/media/nxp,imx8-jpeg.yaml | 45 +++++++++---------- > 1 file changed, 21 insertions(+), 24 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > index 3d9d1db37040..4bcfc815c894 100644 > --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > @@ -32,19 +32,26 @@ properties: > maxItems: 1 > > interrupts: > - description: | > - There are 4 slots available in the IP, which the driver may use > - If a certain slot is used, it should have an associated interrupt > - The interrupt with index i is assumed to be for slot i > - minItems: 1 # At least one slot is needed by the driver > - maxItems: 4 # The IP has 4 slots available for use > + description: > + Interrupt number for slot > + maxItems: 1 > > power-domains: > description: > List of phandle and PM domain specifier as documented in > Documentation/devicetree/bindings/power/power_domain.txt > - minItems: 2 # Wrapper and 1 slot > - maxItems: 5 # Wrapper and 4 slots > + minItems: 1 # VPUMIX > + maxItems: 2 # Wrapper and 1 slot > + > + nxp,slot: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Integer number of slot index used. There are 4 slots available in the IP, > + and driver can use a certain slot, it should have an associated interrupt > + and power-domain. In theory, it supports 4 os or vm. If not specified, 0 > + is used by default. > + minimum: 0 > + maximum: 3 NAK, you still did not answer concerns why this is needed and justified. I keep asking and you keep ignoring... Best regards, Krzysztof
