On Mon, Sep 25, 2023 at 08:48:01AM +0000, Ming Qian wrote: > >From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > >Sent: 2023年9月25日 16:33 > >To: Ming Qian <ming.qian@xxxxxxx>; Mirela Rabulea (OSS) > ><mirela.rabulea@xxxxxxxxxxx>; robh+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx > >Cc: krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; > >mchehab@xxxxxxxxxx; hverkuil-cisco@xxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; > >kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; X.H. Bao > ><xiahong.bao@xxxxxxx>; Eagle Zhou <eagle.zhou@xxxxxxx>; Tao Jiang > ><tao.jiang_2@xxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx>; > >devicetree@xxxxxxxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx; linux- > >kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > >Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: Assign slot > >for imx jpeg encoder/decoder > > > >Caution: This is an external email. Please take care when clicking links or > >opening attachments. When in doubt, report the message using the 'Report > >this email' button > > > > > >On 25/09/2023 10:20, Ming Qian wrote: > >>> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > >>> Sent: 2023年9月25日 16:14 > >>> To: Ming Qian <ming.qian@xxxxxxx>; Mirela Rabulea (OSS) > >>> <mirela.rabulea@xxxxxxxxxxx>; robh+dt@xxxxxxxxxx; > >shawnguo@xxxxxxxxxx > >>> Cc: krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; > >>> mchehab@xxxxxxxxxx; hverkuil-cisco@xxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; > >>> kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; X.H. Bao > >>> <xiahong.bao@xxxxxxx>; Eagle Zhou <eagle.zhou@xxxxxxx>; Tao Jiang > >>> <tao.jiang_2@xxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx>; > >>> devicetree@xxxxxxxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx; linux- > >>> kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > >>> Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: > >>> Assign slot for imx jpeg encoder/decoder > >>> > >>> Caution: This is an external email. Please take care when clicking > >>> links or opening attachments. When in doubt, report the message using > >>> the 'Report this email' button > >>> > >>> > >>> On 25/09/2023 10:13, Ming Qian wrote: > >>>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > >>>>> Sent: 2023年9月25日 16:10 > >>>>> To: Ming Qian <ming.qian@xxxxxxx>; Mirela Rabulea (OSS) > >>>>> <mirela.rabulea@xxxxxxxxxxx>; robh+dt@xxxxxxxxxx; > >>> shawnguo@xxxxxxxxxx > >>>>> Cc: krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; > >>>>> mchehab@xxxxxxxxxx; hverkuil-cisco@xxxxxxxxx; > >>>>> s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; > >>>>> X.H. Bao <xiahong.bao@xxxxxxx>; Eagle Zhou <eagle.zhou@xxxxxxx>; > >>>>> Tao Jiang <tao.jiang_2@xxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx>; > >>>>> devicetree@xxxxxxxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx; linux- > >>>>> kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > >>>>> Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: > >>>>> Assign slot for imx jpeg encoder/decoder > >>>>> > >>>>> Caution: This is an external email. Please take care when clicking > >>>>> links or opening attachments. When in doubt, report the message > >>>>> using the 'Report this email' button > >>>>> > >>>>> > >>>>> On 25/09/2023 10:07, Ming Qian wrote: > >>>>>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > >>>>>>> Sent: 2023年9月25日 16:02 > >>>>>>> To: Ming Qian <ming.qian@xxxxxxx>; Mirela Rabulea (OSS) > >>>>>>> <mirela.rabulea@xxxxxxxxxxx>; robh+dt@xxxxxxxxxx; > >>>>> shawnguo@xxxxxxxxxx > >>>>>>> Cc: krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; > >>>>>>> mchehab@xxxxxxxxxx; hverkuil-cisco@xxxxxxxxx; > >>>>>>> s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; > >>>>>>> festevam@xxxxxxxxx; X.H. Bao <xiahong.bao@xxxxxxx>; Eagle Zhou > >>>>>>> <eagle.zhou@xxxxxxx>; Tao Jiang <tao.jiang_2@xxxxxxx>; > >>>>>>> dl-linux-imx <linux-imx@xxxxxxx>; devicetree@xxxxxxxxxxxxxxx; > >>>>>>> linux-media@xxxxxxxxxxxxxxx; linux- kernel@xxxxxxxxxxxxxxx; > >>>>>>> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > >>>>>>> Subject: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: > >>>>>>> Assign slot for imx jpeg encoder/decoder > >>>>>>> > >>>>>>> Caution: This is an external email. Please take care when > >>>>>>> clicking links or opening attachments. When in doubt, report the > >>>>>>> message using the 'Report this email' button > >>>>>>> > >>>>>>> > >>>>>>> On 25/09/2023 09:41, Ming Qian wrote: > >>>>>>>> There are total 4 slots available in the IP, and we only need to > >>>>>>>> use one slot in one os, assign a single slot, configure > >>>>>>>> interrupt and power domain only for 1 slot, not for the all 4 slots. > >>>>>>> > >>>>>>> No changelog and I do not see much of improvements. Do not ignore > >>>>>>> the feedback but respond to it or fix the patch. Really, what > >>>>>>> happened > >>> here? > >>>>>>> > >>>>>> > >>>>>> Hi Krzysztof, > >>>>>> What do you mean wrap commit message? Do you mean line > >wrapped > >>> at > >>>>> 75 columns? > >>>>>> > >>>>>> - The body of the explanation, line wrapped at 75 columns, which will > >>>>>> be copied to the permanent changelog to describe this patch. > >>>>> > >>>>> I gave you clear link to the doc explaining this. What is unclear there? > >>>>> > >>>>> And you decide to ignore all the rest of the comments here as well? > >>> > >>> So this is still ignored? Can you respond to all my comments? > >>> > >>>>> > >>>>> Best regards, > >>>>> Krzysztof > >>>> > >>>> The link content is as below: > >>>> > >>>> - The body of the explanation, line wrapped at 75 columns, which will > >>>> be copied to the permanent changelog to describe this patch. > >>>> > >>>> I'm sorry that I didn’t get your point. > >>> > >>> Wrap > >>> your > >>> commit > >>> according > >>> to > >>> coding > >>> style. > >>> > >>> Best regards, > >>> Krzysztof > >> > >> Hi Krzysztof, > >> I opened your link about the Linux coding style / submission process, but I > >only find the following message: > >> > >> - The body of the explanation, line wrapped at 75 columns, which will > >> be copied to the permanent changelog to describe this patch. > >> > >> So I don't know what do you mean the coding style. > > > > > >Linked document explains what is a patch, how it is formatted. Just read > >entire doc, not one sentence. > > > >You keep ignoring my other comments all the time, so I will stop asking you to > >respond to them. Instead I will be NAK-ing your patches till you decide to > >respond. > > > >Best regards, > >Krzysztof > > Hi Krzysztof, > I'm sorry that I make you unhappy, as I didn't know how to improve the commit message. > And your other comments about the change, I get your point, and prepare to improve in the next version. > > Sorry again that I didn't response your every comments, I will avoid doing it again. > > And can you give a example how to improve the commit message. 'git log' There are 10K+ examples every 2 months. Please talk to your NXP colleagues experienced with upsteam about how to write and submit patches upstream, and explain what Krzysztof has said if it is not clear. Rob
