On 25/09/2023 09:41, Ming Qian wrote: > There are total 4 slots available in the IP, > and we only need to use one slot in one os, > assign a single slot, > configure interrupt and power domain only for 1 slot, > not for the all 4 slots. No changelog and I do not see much of improvements. Do not ignore the feedback but respond to it or fix the patch. Really, what happened here? Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 > > Signed-off-by: Ming Qian <ming.qian@xxxxxxx> > --- > .../bindings/media/nxp,imx8-jpeg.yaml | 42 ++++++++----------- > 1 file changed, 18 insertions(+), 24 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > index 3d9d1db37040..df381b21336d 100644 > --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > @@ -32,25 +32,29 @@ properties: > maxItems: 1 > > interrupts: > - description: | > - There are 4 slots available in the IP, which the driver may use > - If a certain slot is used, it should have an associated interrupt > - The interrupt with index i is assumed to be for slot i > - minItems: 1 # At least one slot is needed by the driver > - maxItems: 4 # The IP has 4 slots available for use > + description: > + Interrupt number for slot > + maxItems: 1 > > power-domains: > description: > List of phandle and PM domain specifier as documented in > Documentation/devicetree/bindings/power/power_domain.txt > - minItems: 2 # Wrapper and 1 slot > - maxItems: 5 # Wrapper and 4 slots > + minItems: 1 # VPUMIX > + maxItems: 2 # Wrapper and 1 slot > + > + nxp,slot: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Integer number of slot index used. > + minimum: 0 > + maximum: 3 Nothing explains what is a slot and nothing explains why do you need this property. > > required: > - compatible > - reg > - interrupts > - power-domains > + - nxp,slot NAK, that's an ABI break. Best regards, Krzysztof
