On Wed, 13 Sept 2023 at 14:56, Laurent Pinchart
<laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
>
> The IMX219_REG_CSI_LANE_MODE is configured twice, once with a hardcoded
> value in the imx219_common_regs registers array, and once with the value
> appropriate for the system in imx219_configure_lanes(). The latter is
> enough, drop the former.
>
> Fixes: ceddfd4493b3 ("media: i2c: imx219: Support four-lane operation")
> Suggested-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
Reviewed-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>
> ---
> drivers/media/i2c/imx219.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
> index fbf4c69577f7..d8840aa67c42 100644
> --- a/drivers/media/i2c/imx219.c
> +++ b/drivers/media/i2c/imx219.c
> @@ -214,7 +214,6 @@ static const struct cci_reg_sequence imx219_common_regs[] = {
> { IMX219_REG_Y_ODD_INC_A, 1 },
>
> /* Output setup registers */
> - { IMX219_REG_CSI_LANE_MODE, IMX219_CSI_2_LANE_MODE },
> { IMX219_REG_DPHY_CTRL, IMX219_DPHY_CTRL_TIMING_AUTO },
> { IMX219_REG_EXCK_FREQ, IMX219_EXCK_FREQ(IMX219_XCLK_FREQ / 1000000) },
> };
> --
> Regards,
>
> Laurent Pinchart
>
