On 15/09/2023 23:11, Sebastian Fricke wrote: > From: Robert Beckett <bob.beckett@xxxxxxxxxxxxx> > > Add bindings for the wave5 chips&media codec driver > > Signed-off-by: Robert Beckett <bob.beckett@xxxxxxxxxxxxx> > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@xxxxxxxxxxxxx> > Signed-off-by: Sebastian Fricke <sebastian.fricke@xxxxxxxxxxxxx> So this is v12 and still no tested? A nit, subject: drop second/last, redundant "yaml devicetree indings". The "dt-bindings" prefix is already stating that these are bindings. Basically three words bringing zero information. > --- > .../devicetree/bindings/media/cnm,wave5.yaml | 66 ++++++++++++++++++++++ > 1 file changed, 66 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/cnm,wave5.yaml b/Documentation/devicetree/bindings/media/cnm,wave5.yaml > new file mode 100644 > index 000000000000..b8f383621805 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/cnm,wave5.yaml > @@ -0,0 +1,66 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/cnm,wave5.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Chips&Media Wave 5 Series multi-standard codec IP > + > +maintainers: > + - Nas Chung <nas.chung@xxxxxxxxxxxxxxx> > + - Jackson Lee <jackson.lee@xxxxxxxxxxxxxxx> > + > +description: |- Do not need '|-' unless you need to preserve formatting. > + The Chips&Media WAVE codec IP is a multi format video encoder/decoder > + > +properties: > + compatible: > + enum: > + - cnm,cm521c-vpu It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. Missing blank line > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: VCODEC clock > + > + clock-names: > + items: > + - const: vcodec Drop clock-names, not really useful for one entry. > + > + interrupts: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + sram: > + $ref: /schemas/types.yaml#/definitions/phandle > + Drop blank line > + description: > + The VPU uses the SRAM to store some of the reference data instead of > + storing it on DMA memory. It is mainly used for the purpose of reducing > + bandwidth. > + > +required: > + - compatible > + - reg > + - interrupts Keep the same order as listed in properties: > + - clocks > + - clock-names > + > +additionalProperties: false > + Best regards, Krzysztof
