Hi Fabio,
On Wed, Sep 13, 2023 at 04:39:32PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@xxxxxxx>
>
> The powerdown-gpios description mentions:
>
> "Reference to the GPIO connected to the PWDN pin which is active high."
>
> Improve the example by making powerdown-gpios active-high for consistency.
>
> Signed-off-by: Fabio Estevam <festevam@xxxxxxx>
> ---
> Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
> index 5d24edba8f99..5aec65b053af 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
> @@ -114,7 +114,7 @@ examples:
> compatible = "ovti,ov7725";
> reg = <0x21>;
> reset-gpios = <&axi_gpio_0 0 GPIO_ACTIVE_LOW>;
> - powerdown-gpios = <&axi_gpio_0 1 GPIO_ACTIVE_LOW>;
> + powerdown-gpios = <&axi_gpio_0 1 GPIO_ACTIVE_HIGH>;
> clocks = <&xclk>;
>
> port {
Looking at the driver code, it seems the powerdown GPIO is set to state 1
when the device is powered on and to 0 when it's powered down. This looks
like a driver bug.
But what happens if you fix something like this after five years in
existence? Maybe just leave it as-is, and document it??? Then again,
there's a single Renesas board that appears to have such a device, added
two and half years ago.
Also cc Jacopo.
--
Regards,
Sakari Ailus
