Re: [PATCH] viafb camera controller driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 11 Oct 2010 14:18:55 +0200
Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:

> > +static __devexit int viacam_remove(struct platform_device *pdev)
> > +{
> > +	struct via_camera *cam = via_cam_info;  
> 
> And use it here.
> 
> Just call platform_set_drvdata(pdev, cam) in viacam_probe to store the struct 
> via_camera pointer in the platform device, and platform_get_drvdata(pdev) here 
> to retrieve it.

Yes, I know...but the fix isn't quite that simple because the platform
data is already used elsewhere.  What's needed is some sort of "viafb
subdevice instance" structure which can keep all of the pointers
together.  My plan is to do that, but it will require via-core changes
and I just don't have time for that right now.

Can I get away with this (it will cause no real-world trouble) with a
promise of a fix in the next month or two?  I have some other via-core
stuff (suspend/resume in particular) that I need to do anyway.

Thanks,

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux